-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
soc: atmel: sam/sam0: Add platform specific initialization #61005
Merged
carlescufi
merged 6 commits into
zephyrproject-rtos:main
from
nandojve:sam/add_platform_specific_init
Aug 4, 2023
Merged
soc: atmel: sam/sam0: Add platform specific initialization #61005
carlescufi
merged 6 commits into
zephyrproject-rtos:main
from
nandojve:sam/add_platform_specific_init
Aug 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4810844
to
ed4c27d
Compare
pdgendt
previously approved these changes
Aug 1, 2023
This update Kconfig.series files to normalize copyright date order from lower to higher and reorder select entries. Signed-off-by: Gerson Fernando Budke <nandojve@gmail.com>
This reorder <board>_defconfig entries in soc/board, internal and driver definitions. Signed-off-by: Gerson Fernando Budke <nandojve@gmail.com>
Adjust copyright order by ascending year order. Signed-off-by: Gerson Fernando Budke <nandojve@gmail.com>
This replace pre kernel initialization by the platform specific initialization call. The platform specific init will configure at very beginning the clocks, flash wait states and cache. Signed-off-by: Gerson Fernando Budke <nandojve@gmail.com>
The current platform initialization do not take in consideration cache management for historic reasons. This fixes any miss configuration and allow users to enable/disable caches at board definition. The default value is cache disabled and the below examples are for SAMV71 which have both I/D Cache available: I Cache only: CONFIG_CACHE_MANAGEMENT=y CONFIG_DCACHE=n D Cache only: CONFIG_CACHE_MANAGEMENT=y CONFIG_ICACHE=n I/D Cache disabled: CONFIG_ICACHE=n CONFIG_DCACHE=n I/D Cache Enabled: CONFIG_CACHE_MANAGEMENT=y Signed-off-by: Gerson Fernando Budke <nandojve@gmail.com>
The sam0 CMCC configure Cortex-M cache controller. However, it is not clear how the cache management should be performed. It is nor clear if instructions like SCB_EnableICache can be used. In this case, if cache management should be made only by CMCC it may require a dedicated implementation. Besides above, the CPU_CORTEX_M4 do not define cache by default which can signal a bad configuration in tree since the SOC_SERIES_SAME54 do not define which caches should be available. This force cache controller disable to avoid issues. Signed-off-by: Gerson Fernando Budke <nandojve@gmail.com>
ed4c27d
to
b553db3
Compare
pdgendt
approved these changes
Aug 3, 2023
attie-argentum
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replace pre kernel initialization by the platform specific initialization call. The platform specific init will configure at very beginning the clocks, flash wait states and cache.
Supersedes #60425